Skip to content

Conversation

@smarcet
Copy link
Collaborator

@smarcet smarcet commented Jun 13, 2024

@smarcet smarcet requested a review from romanetar June 13, 2024 20:24
@smarcet smarcet changed the title Feature/lv11 version feat: update LV from 10.X to 11.X Jun 13, 2024
@smarcet smarcet force-pushed the feature/lv11-version branch 3 times, most recently from 99d1f16 to ed9e9d9 Compare June 19, 2024 13:47
@smarcet smarcet force-pushed the feature/lv11-version branch 3 times, most recently from 123a001 to 9cded7a Compare June 26, 2024 21:08
@smarcet smarcet force-pushed the main branch 6 times, most recently from ee2739d to 75a2b2d Compare July 10, 2024 23:04
@smarcet smarcet force-pushed the feature/lv11-version branch 4 times, most recently from 505f4bd to df12ed6 Compare July 15, 2024 16:59
@smarcet smarcet force-pushed the main branch 2 times, most recently from bc7b2f6 to b8805ef Compare July 15, 2024 17:43
@smarcet smarcet force-pushed the feature/lv11-version branch 3 times, most recently from 608e423 to 5a65c6e Compare July 16, 2024 21:33
@smarcet smarcet force-pushed the feature/lv11-version branch from 5a65c6e to 5042915 Compare July 23, 2024 17:37
@smarcet smarcet force-pushed the feature/lv11-version branch from 5042915 to 3383b16 Compare August 8, 2024 16:38
@smarcet smarcet force-pushed the main branch 3 times, most recently from 0ce1033 to 68abad0 Compare September 7, 2024 18:14
romanetar and others added 25 commits May 7, 2025 15:58
Signed-off-by: romanetar <roman_ag@hotmail.com>
Signed-off-by: romanetar <roman_ag@hotmail.com>
Signed-off-by: romanetar <roman_ag@hotmail.com>
chore: refactor dev docker file

Change-Id: Ic5b4d3ac14d896cb7186615661e94955d762477c
Signed-off-by: romanetar <roman_ag@hotmail.com>
Signed-off-by: smarcet <smarcet@gmail.com>
Signed-off-by: smarcet <smarcet@gmail.com>
* removed doctrine deprecated methods
* upgraded deps
chore: update auth schemas as suggested on upgrade doc
Change-Id: Ib303237acec136dcd4d54453f814cb975c897e30
Change-Id: I11e4b11563c6725e5b7671a10ec26484ea739bf1
Change-Id: I4324b4fe3812f8d15b335464ca13ca5fed9ddb5e
@smarcet smarcet force-pushed the feature/lv11-version branch from 264d71c to da26552 Compare May 7, 2025 18:58
@smarcet smarcet requested a review from Copilot May 7, 2025 18:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to LV11.X by replacing Zend packages with Laminas alternatives, updating middleware and Docker configurations, and introducing updated annotation and logging patterns.

  • Replaces Zend components with Laminas equivalents
  • Updates middleware configurations and CI workflows
  • Upgrades PHP and Xdebug versions in the Dockerfile

Reviewed Changes

Copilot reviewed 118 out of 118 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/libs/OAuth2/Models/AccessToken.php Replaces Zend\Math\Rand with Laminas\Math\Rand
app/libs/OAuth2/GrantTypes/InteractiveGrantType.php Updates comment and logout method usage
app/libs/Auth/Models/User.php Updates ORM annotations and adds getAuthPasswordName method
app/libs/Auth/CustomAuthProvider.php Adds a stub for rehashPasswordIfRequired
app/libs/Auth/AuthService.php Introduces optional parameter in logout method with doc comments
app/libs/Auth/AuthHelper.php Replaces Zend libraries with Laminas libraries
app/Services/Utils/DoctrineTransactionService.php Adjusts transaction management and error handling
app/Services/UserActionService.php Adds a debug log message for user actions
app/Services/OAuth2/TokenService.php Updates Laminas Crypt usage
app/Services/OAuth2/ClientCredentialGenerator.php Replaces Zend\Math\Rand with Laminas\Math\Rand
app/Providers/EventServiceProvider.php Updates email method from setTo to to for compatibility
app/Models/OAuth2/OAuth2OTP.php Replaces Zend\Math\Rand with Laminas\Math\Rand
app/Http/Utils/Log/LaravelMailerHandler.php Updates mailer method calls for sending HTML emails
app/Http/Kernel.php Updates CORS middleware reference
app/Http/Controllers/Api/ClientPublicKeyApiController.php Changes validation rule parameter from client_id to owner_id
Dockerfile Upgrades base PHP version and updates Xdebug version
.github/workflows/* Updates CI/CD workflows to modern containerless concepts with updated environment variables
Comments suppressed due to low confidence (1)

app/libs/OAuth2/GrantTypes/InteractiveGrantType.php:659

  • Fix the typo in the comment: change 'teh' to 'the'.
// must required teh auth_time claim

Copy link
Contributor

@romanetar romanetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit ae24738 into main May 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants